search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Display copy + launch errors #593

Closed ThomasThelen closed 4 years ago

ThomasThelen commented 4 years ago

This PR adds a modal dialog that opens when copy + launching fails. This fixes the issue where the user wasn't getting a notification that they already had two instances running. Fixes #522

WGdUlAuBXw

To Test:

  1. Deploy this branch
  2. Launch two instances
  3. Attempt to copy + launch a Tale you don't own
  4. See the error notification
craig-willis commented 4 years ago

@ThomasThelen Are you planning to address the refresh problem?

ThomasThelen commented 4 years ago

@craig-willis I'll look into it today

ThomasThelen commented 4 years ago

I'm seeing this bahaviour on stage right now, if it's fine with both of you I'd like to fix it in another issue/PR.