whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Increase max length of tale title on Run view paddleboard #600

Closed bodom0015 closed 4 years ago

bodom0015 commented 4 years ago

Problem

Tale title is truncated too early on the Run view's paddleboard.

Fixes #449

Approach

Increase the maximum number of characters to 100 before title is truncated.

How to Test

  1. Checkout and run this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Create a Tale with a long name, if you haven't already
  4. Navigate to the Run view for this Tale
    • You should be brought to the Run view for this Tale
    • You should see that 100 characters are allowed in the title before truncation occurs
Xarthisius commented 4 years ago

I'd like to state in advance that I understand that the number of WT users running a tiling window manager is close to 0, but can we make the number of characters somehow depend on the width of the screen? See below:

screen

bodom0015 commented 4 years ago

@Xarthisius ignoring the fact that we haven't tested much with smaller screen resolutions, we can use Semantic UI's built-in CSS classes to set a max length for each screen type...

I've arbitrarily set these widths to the following for now, and we can adjust as needed:

bodom0015 commented 4 years ago

@craig-willis I just guessed on the max length for each screen size, so 100 might have been too many for this case... Maybe it should be limited to 60 instead?

If there are better numbers to use it's easy enough to change them here. The title truncation should still dynamically change with the screen size (which can be tested by resizing the window)

I will say that I don't think it's worth it to build anything further / custom for this.