search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Restart Tale on a stopped Tale yields a 500 #601

Open bodom0015 opened 4 years ago

bodom0015 commented 4 years ago

We should probably disable the "Restart Tale" dropdown option if the Tale isn't running

Steps to Reproduce

  1. Login to the WholeTale Dashboard
  2. Create a Tale, but don't launch it
  3. Navigate to the Run view for the Tale
  4. Expand the dropdown at the top-right and select Restart Tale

Expected Results Nothing should happen - there is no Tale to restart. Dropdown option should probably be disabled in this case.

Actual Results The API server throws a 500.

bodom0015 commented 4 years ago

Since you can't Restart without hitting Run first, I propose moving "Restart" to be in-line with Run and Close. That way, it will make sense to show/hide this option as the Tale state changes (unlike the items in the current dropdown list)

If this would take up too much space on the paddleboard, we can always use a dropdown action selector, similar to the "Create and Launch Tale" behavior on the create-tale-modal.

bodom0015 commented 4 years ago

Kyle and others reported this at the 2020 AHM.

Also noting that this option (as well as "Rebuild Tale") show for Tale's that the user does not own.

These options should be disabled (or ideally, hidden entirely) in this case