search

whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Tale images not shown on browse page #604

Closed craig-willis closed 4 years ago

craig-willis commented 4 years ago

We removed https://github.com/whole-tale/dashboard/pull/599 from rc2 because of an apparent side-effect related to displaying the tale images on the browse page.

I'm seeing this on my dev instance now on master. If I click "My Tales" the image displays:

Screen Shot 2020-02-28 at 9 12 38 AM
bodom0015 commented 4 years ago

Steps to Reproduce

  1. Clear localStorage manually or close all incognito windows and open a fresh incognito window
  2. Navigate to Browse

Expected Results List of Tales should be displayed with their images

Actual Results No Tale images are displayed, even though all Tales are still listed here

Root Cause We aren't properly setting the filter value when no saved value is detected in localStorage

PR incoming