whole-tale / dashboard

Whole Tale Dashboard
http://wholetale.org
MIT License
7 stars 2 forks source link

Redirect to run page on errors #611

Closed ThomasThelen closed 4 years ago

ThomasThelen commented 4 years ago

Redirects the user to the Tale if there is an error launching the Tale. This behaviour was built into the create-tale-modal, but we were showing the modal before loading this behavior.

This is a fix for #597 . After navigating to the run page and back the browse, users should see their Tale

Test Steps:

  1. Checkout and deploy
  2. Launch two Tales
  3. Copy + Launch a Tale
  4. After the error message make sure you're brought to the run page
  5. Navigate to Browse
  6. See your Tale
  7. Create and launch a new Tale (with the two instances still running)
  8. After the error message note that you're brought to the run page
  9. Navigate to Browse
  10. See your Tale

Side Note: I found another duplicate modal issue. After viewing the run page and going back to browse... If you copy + launch again you'll get two error modals.