My previous testing was done on larger monitors, but it seems like my 13-inch laptop screen has issues with max-height: 600px on the select-data-modal. If the list grows too long, the Submit button can be pushed off the screen, despite having set a max-height.
Approach
Shrank to max-height: 400px so that it will fit smaller laptop screens.
Ideally, this would be a percentage or use a value like 50vh or similar to assign a fraction (e.g. 50%) of the viewport height, but this would take more experimentation with a larger selection of monitors that I don't have at my disposal.
How to Test
Checkout and run this branch locally
Login to the WholeTale Dashboard
Register ~12 datasets (enough to enable scrolling on the select-data-modal)
Create a Tale, if you haven't already
Navigate to Run > Files > External Data for the Tale
Click the (+) to open the select-data-modal
You should see that the left side provides a scroll bar
You should see the "Cancel" and "Submit" buttons are on the screen
Add all datasets to the Tale
You should see that the right side provides a scroll bar
You should see the "Cancel" and "Submit" buttons are still on the screen
Problem
My previous testing was done on larger monitors, but it seems like my 13-inch laptop screen has issues with
max-height: 600px
on theselect-data-modal
. If the list grows too long, the Submit button can be pushed off the screen, despite having set amax-height
.Approach
Shrank to
max-height: 400px
so that it will fit smaller laptop screens.Ideally, this would be a percentage or use a value like
50vh
or similar to assign a fraction (e.g. 50%) of the viewport height, but this would take more experimentation with a larger selection of monitors that I don't have at my disposal.How to Test
select-data-modal
)select-data-modal