search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Remove a deceitful 'token' argument that disguised itself as a 'name'… #460

Closed Xarthisius closed 3 years ago

Xarthisius commented 3 years ago

… kwarg in createInstance.

How to test?

  1. Import something as binder and/or from a git repo with spawn=True
  2. Verify that instance name is not your token...
codecov[bot] commented 3 years ago

Codecov Report

Merging #460 (c65c65b) into master (c8a72c5) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   92.00%   92.00%   -0.01%     
==========================================
  Files          52       52              
  Lines        3929     3927       -2     
==========================================
- Hits         3615     3613       -2     
  Misses        314      314
Impacted Files Coverage Δ
server/models/instance.py 82.19% <100.00%> (ø)
server/tasks/import_binder.py 92.17% <100.00%> (ø)
server/tasks/import_git_repo.py 97.56% <100.00%> (-0.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8a72c5...c65c65b. Read the comment docs.