whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Update MDF provider. Fixes #466 #467

Closed Xarthisius closed 3 years ago

Xarthisius commented 3 years ago

I think this is a third consecutive release where we discover that registering MDF resources is broken. That tells me two things:

  1. Our testing plan is really good (thanks @bodom0015)
  2. Nobody is using this in production.

Per 2. if that ever happens again (my bet: during v1.1 release) my next PR with a "fix" will simply drop MDF support.

How to test?

  1. Follow the testing plan concerning registration of Globus resources.
codecov[bot] commented 3 years ago

Codecov Report

Merging #467 (3e65293) into master (1daff5c) will increase coverage by 0.61%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   92.11%   92.73%   +0.61%     
==========================================
  Files          52       52              
  Lines        3920     3923       +3     
==========================================
+ Hits         3611     3638      +27     
+ Misses        309      285      -24     
Impacted Files Coverage Δ
server/lib/globus/globus_provider.py 63.80% <100.00%> (+18.71%) :arrow_up:
server/utils.py 92.30% <0.00%> (+15.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1daff5c...3e65293. Read the comment docs.

craig-willis commented 3 years ago

The dataset registers for me, but when I try to access a file I get the following trace in Girder:

[2021-05-02 18:38:29,560] ERROR: Traceback (most recent call last):
[2021-05-02 18:38:29,561] ERROR:   File "/girder/plugins/wt_data_manager/server/lib/transfer_manager.py", line 24, in run
[2021-05-02 18:38:29,561] ERROR:     self.transferHandler.run()
[2021-05-02 18:38:29,561] ERROR:   File "/girder/plugins/wt_data_manager/server/lib/tm_utils.py", line 34, in run
[2021-05-02 18:38:29,561] ERROR:     self.transfer()
[2021-05-02 18:38:29,562] ERROR:   File "/girder/plugins/wt_data_manager/server/lib/handlers/globus.py", line 30, in transfer
[2021-05-02 18:38:29,562] ERROR:     self._maybeStartServer()
[2021-05-02 18:38:29,562] ERROR:   File "/girder/plugins/wt_data_manager/server/lib/handlers/globus.py", line 106, in _maybeStartServer
[2021-05-02 18:38:29,562] ERROR:     self.server.start()
[2021-05-02 18:38:29,563] ERROR:   File "/girder/plugins/globus_handler/server/server.py", line 57, in start
[2021-05-02 18:38:29,563] ERROR:     (self.endpointId, self.endpointName) = self._createEndpoint()
[2021-05-02 18:38:29,563] ERROR:   File "/girder/plugins/globus_handler/server/server.py", line 223, in _createEndpoint
[2021-05-02 18:38:29,563] ERROR:     _runGCCommand('%s/globusconnectpersonal' % self.gcDir, '-setup', setupKey, '-dir',
[2021-05-02 18:38:29,563] ERROR:   File "/girder/plugins/globus_handler/server/server.py", line 19, in _runGCCommand
[2021-05-02 18:38:29,564] ERROR:     raise Exception(msg)
[2021-05-02 18:38:29,564] ERROR: Exception: Command ('/opt/globusconnectpersonal/globusconnectpersonal', '-setup', '7c3058ba-e18f-4317-8b1c-37586b84f7da', '-dir', '/home/girder/.WholeTale/0baa7c04-1ff6-4cf5-82b3-00dd47e828d9') failed with exit code 2:
[2021-05-02 18:38:29,564] ERROR: b'usage: register [-h] [--attributes [file:PATH|JSON_DATA]] [-n NAME]\n                [--description DESCRIPTION] [--owner OWNER] [-z]\n                [--high-assurance] [--atm AUTHENTICATION_TIMEOUT_MINUTES]\n                [--setup-key SETUP_KEY] [--environment {preview,production}]\n                [SETUP_KEY]\nregister: error: unrecognized arguments: -dir /home/girder/.WholeTale/0baa7c04-1ff6-4cf5-82b3-00dd47e828d9\n\nSetup did not complete successfully.\nYou may want to check /home/girder/.globusonline/lta/register.log for more information\n'

My Globus config may be bad, but the the "unrecognized argument" is suspicious -- and likely a separate issue from this one.