search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Update tale's icon field whenever imageId changes. Fixes #473 #474

Closed Xarthisius closed 3 years ago

Xarthisius commented 3 years ago

Test case in #473.

codecov[bot] commented 3 years ago

Codecov Report

Merging #474 (9f81128) into master (bb2d57b) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   92.11%   92.12%           
=======================================
  Files          52       52           
  Lines        3921     3922    +1     
=======================================
+ Hits         3612     3613    +1     
  Misses        309      309
Impacted Files Coverage Δ
server/rest/tale.py 95.12% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb2d57b...9f81128. Read the comment docs.

Xarthisius commented 3 years ago

Why have I never noticed this? Works for me.

Judging by the amount of problems I found when I tried to switch base image on an existing Tale (https://github.com/whole-tale/gwvolman/issues/143 https://github.com/whole-tale/gwvolman/pull/142 and this) we haven't been really considering this workflow in our testing.