whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Send notification after instance update #480

Closed craig-willis closed 3 years ago

craig-willis commented 3 years ago

This PR moves the event notification until after the instance (status) has been saved.

codecov[bot] commented 3 years ago

Codecov Report

Merging #480 (acf8554) into master (0a248a6) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   92.75%   92.78%   +0.03%     
==========================================
  Files          52       52              
  Lines        3932     3936       +4     
==========================================
+ Hits         3647     3652       +5     
+ Misses        285      284       -1     
Impacted Files Coverage Δ
server/models/instance.py 85.23% <100.00%> (+1.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a248a6...acf8554. Read the comment docs.