search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Decrease the amount of Tale().updateTale calls during import #484

Closed Xarthisius closed 3 years ago

Xarthisius commented 3 years ago

As a result there should be less spurious notifications sent to the users, which should make whole-tale/ngx-dashboard#181 less noticeable. Also updating a single field instead of entire documents seems like a right thing to do in case of status updates.

How to test?

It's basically a noop PR. Not sure how to test it properly... Do some imports and confirm everything still works?

codecov[bot] commented 3 years ago

Codecov Report

Merging #484 (3e111d8) into master (4ce464d) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   92.78%   92.75%   -0.03%     
==========================================
  Files          52       52              
  Lines        3936     3921      -15     
==========================================
- Hits         3652     3637      -15     
  Misses        284      284
Impacted Files Coverage Δ
server/tasks/copy_workspace.py 100.00% <100.00%> (ø)
server/tasks/import_binder.py 92.04% <100.00%> (-0.18%) :arrow_down:
server/tasks/import_git_repo.py 97.43% <100.00%> (-0.13%) :arrow_down:
server/tasks/import_tale.py 98.79% <100.00%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ce464d...3e111d8. Read the comment docs.