search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Dataverse provider updates #500

Closed Xarthisius closed 3 years ago

Xarthisius commented 3 years ago

Multiple issue related to registering data from DV crept up. Mostly due to the fact that we are using "prerecorded" request responses in our test suite. Some of the issues can be solved on our end:

  1. Urlib requests to DV result in 403 for some reason. Solution: switch to requests
  2. DV started to encode filenames in Content-Disposition headers, but they're doing it in two different ways (see https://github.com/IQSS/dataverse/issues/7962). Solution: decode...

Remaining issue causing breakage is isolated to Harvard's DV instance. Namely, search with query parameter entityId is not working there properly. I filed a ticket about it but unfortunately it's on a private tracker.

codecov[bot] commented 3 years ago

Codecov Report

Merging #500 (6299100) into master (c766064) will decrease coverage by 0.01%. The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   93.18%   93.16%   -0.02%     
==========================================
  Files          52       52              
  Lines        3960     3937      -23     
==========================================
- Hits         3690     3668      -22     
+ Misses        270      269       -1
Impacted Files Coverage Δ
server/lib/dataverse/provider.py 96.89% <95.65%> (+0.97%) :arrow_up:
server/lib/http_provider.py 87.87% <100.00%> (-0.19%) :arrow_down:
server/lib/resolvers.py 95.65% <100.00%> (-1.28%) :arrow_down:
server/lib/dataone/register.py 83.45% <0.00%> (-0.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c766064...6299100. Read the comment docs.