whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

[WIP] Revamp dataSet in Tales to account for raw data #502

Closed Xarthisius closed 2 months ago

Xarthisius commented 3 years ago

Arguably this work should be submitted as multiple PRs, but I was lazy...

Roughly what it does:

  1. Introduces "Tale's data directory" see: https://hackmd.io/KQ9TzJ7zSrqzaeYGX9ClSQ
  2. Abstracts Zip upload handling from BDBag importer
  3. Adds generic zip provider that allows to dump raw data in to Tale's data directory
  4. Handles existing catalog resources via Tale's datadir

What should work:

What doesn't work:

more info tba

codecov[bot] commented 2 years ago

Codecov Report

Merging #502 (4f65df9) into master (2e2ae35) will decrease coverage by 0.60%. The diff coverage is 84.94%.

:exclamation: Current head 4f65df9 differs from pull request most recent head a57b38b. Consider uploading reports for the commit a57b38b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   93.41%   92.81%   -0.61%     
==========================================
  Files          54       54              
  Lines        4179     4243      +64     
==========================================
+ Hits         3904     3938      +34     
- Misses        275      305      +30     
Impacted Files Coverage Δ
server/schema/tale.py 100.00% <ø> (ø)
server/lib/bdbag/bdbag_provider.py 79.33% <62.96%> (-12.50%) :arrow_down:
server/lib/manifest.py 91.50% <66.66%> (-0.57%) :arrow_down:
server/rest/dataset.py 87.31% <80.00%> (-0.79%) :arrow_down:
server/lib/globus/globus_provider.py 65.48% <91.66%> (+1.67%) :arrow_up:
server/models/tale.py 97.01% <94.44%> (-1.09%) :arrow_down:
server/constants.py 88.63% <100.00%> (+0.26%) :arrow_up:
server/lib/__init__.py 96.07% <100.00%> (+0.07%) :arrow_up:
server/lib/dataone/provider.py 97.05% <100.00%> (+0.23%) :arrow_up:
server/lib/dataverse/provider.py 97.34% <100.00%> (+0.06%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1639360...a57b38b. Read the comment docs.