search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Set 'samesite' to None for sign_in cookies #512

Closed Xarthisius closed 2 years ago

Xarthisius commented 2 years ago

To work properly it also requires secure attribute (preferably set to True). It's already being handled by girder proper. Just do:

PUT /system/setting?key=core.secure_cookie&value=true
codecov[bot] commented 2 years ago

Codecov Report

Merging #512 (a884ffd) into master (2a5ef4c) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          54       54           
  Lines        4157     4159    +2     
=======================================
+ Hits         3882     3884    +2     
  Misses        275      275
Impacted Files Coverage Δ
server/__init__.py 93.25% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a5ef4c...a884ffd. Read the comment docs.