search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Tale's config is not preserved in environment.json during export/version creation. #514

Closed Xarthisius closed 2 years ago

Xarthisius commented 2 years ago

How to reproduce?

  1. Create a Tale with custom config, e.g. {"foo": "bar"}
  2. Either export a bag or create a version.
  3. Inspect environment.json (either in the bag, or in version folder)

Expected result

taleConfig is present and equal to {"foo": "bar"}

Actual result

No taleConfig.

Notes

Originally reported by @matthew-a-dunlap via email.

matthew-a-dunlap commented 2 years ago

Thanks for fixing this for export/versioning. This seems to still be broken when using the PUT /tale/{id}/restore command. I've tested this via the girder page taking a tale with a version and restoring it.

Let me know if I can do anything else to help!

Xarthisius commented 2 years ago

@matthew-a-dunlap The fact it was merged doesn't necessarily mean it was deployed on .stage. Try now.

matthew-a-dunlap commented 2 years ago

@Xarthisius Works now! Thanks for pushing the feature.