Closed Xarthisius closed 2 years ago
Merging #519 (74ac6fd) into master (a251646) will increase coverage by
0.77%
. The diff coverage is95.83%
.
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 92.15% 92.92% +0.77%
==========================================
Files 58 58
Lines 4460 4508 +48
==========================================
+ Hits 4110 4189 +79
+ Misses 350 319 -31
Impacted Files | Coverage Δ | |
---|---|---|
server/lib/deriva/provider.py | 96.66% <92.30%> (+28.66%) |
:arrow_up: |
server/lib/bdbag/bdbag_provider.py | 93.90% <96.15%> (+2.99%) |
:arrow_up: |
server/lib/resolvers.py | 94.02% <100.00%> (+11.94%) |
:arrow_up: |
server/lib/deriva/integration.py | 93.54% <0.00%> (+48.38%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a251646...74ac6fd. Read the comment docs.
This PR adds following enhancement to BDBag and Deriva providers:
manifest-<alg>.txt
files are parsed and checksums are stored on imported girder objects (see eb2a284d73719ca98107bd06eff3e0f90d8e6c01)manifest.json
is parsed to get additional metadata (see https://github.com/whole-tale/girder_wholetale/commit/d8364faf6359fe3a1a62ca24bf63198b4f2d4a5c). It's mostly stored raw on girder objects, with an exception of mimeType that's now properly set on imported items and their identifiers that are taken from bundledAs.uri section (see https://github.com/whole-tale/girder_wholetale/commit/a1db59412cc29535329b63d925dd612417d95623)TODO
How to test?
manifest-md5.txt
,fetch.txt
andmanifest.json
contain a lot of entries/remote files. NOTE: Bags are not necessarily complete, nor useful at this stage. Further enhancements will be surely needed.