Closed Xarthisius closed 2 years ago
Merging #520 (bcd24a0) into master (fd35a45) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 91.78% 91.84% +0.05%
==========================================
Files 58 58
Lines 4443 4450 +7
==========================================
+ Hits 4078 4087 +9
+ Misses 365 363 -2
Impacted Files | Coverage Δ | |
---|---|---|
server/rest/tale.py | 96.44% <100.00%> (ø) |
|
server/tasks/import_binder.py | 93.44% <100.00%> (+1.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd35a45...bcd24a0. Read the comment docs.
I don't understand the motivating case here -- I expected https://github.com/whole-tale/girder_wholetale/pull/519 to require this PR. Why do we need to do this?
I don't understand the motivating case here -- I expected #519 to require this PR. Why do we need to do this?
The motivating case is putting bdbag's data/ in our data/. That will require a few steps. This is the first one. I made it a generic solution, rather than provider specific. Remaining are:
dsRootPath
for import pathdsRootPath=/data
in its integration by default.OK, I get it now. So given the following dataset named "Test Dataset":
folder1/
file2.txt
folder2/
file2.txt
For the following dsRootPath
values I get:
../data/Test Dataset
/
: ../data/folder1
/folder1
: ../data/file2.txt, folder2.txt
I know the idea of the dataset name as a folder has annoyed some and can see why the DERIVA case of ../data/data/... might confuse.
Rationale
Often during registration of a binder/dataset as a Tale we're interested only in a subset of the imported tree. This PR introduces
dsRootPath
parameter toPOST /tale/import
that allows to specify internal dataset path that should be used for generation of Tale'sdataSet
.How to test?
assets
and a bunch of csvs.