whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Add checksumAlgorithm parameter to determine D1 alg used #524

Closed craig-willis closed 2 years ago

craig-willis commented 2 years ago

Problem Repeated registrations of 10.5065/D6862DM8 return different checksum values apparently depending on the D1 server hit.

Solution Add the checksumAlgorithm to the solr query instead of assuming md5.

To test

codecov[bot] commented 2 years ago

Codecov Report

Merging #524 (95d351d) into master (250f92e) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   92.88%   92.86%   -0.03%     
==========================================
  Files          58       58              
  Lines        4513     4513              
==========================================
- Hits         4192     4191       -1     
- Misses        321      322       +1     
Impacted Files Coverage Δ
server/lib/dataone/provider.py 100.00% <ø> (ø)
server/lib/dataone/register.py 76.25% <ø> (ø)
server/lib/dataverse/provider.py 97.09% <0.00%> (-0.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 250f92e...95d351d. Read the comment docs.

craig-willis commented 2 years ago

Adding notes based on Slack discussion for future reference: