search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

[dataverse] expand matching url with the most common path pattern #546

Closed Xarthisius closed 2 years ago

Xarthisius commented 2 years ago

Per Lars' comment /dataset.xhtml?persistentId= is the most common DV url that users see and seems to be unique enough for our purposes to determine that url belongs to Dataverse instance.

How to test?

  1. Lookup doi:10.5683/SP3/WVQ4QH and confirm it's identified as a DV dataset.
codecov[bot] commented 2 years ago

Codecov Report

Merging #546 (3eb98a7) into master (0186a99) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   92.87%   92.89%   +0.02%     
==========================================
  Files          58       58              
  Lines        4560     4560              
==========================================
+ Hits         4235     4236       +1     
+ Misses        325      324       -1
Impacted Files Coverage Δ
server/lib/dataverse/provider.py 97.11% <100.00%> (+0.39%) :arrow_up:
server/lib/import_providers.py 92.15% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0186a99...3eb98a7. Read the comment docs.