search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

fix: respect exisiting version during manifest generation #554

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

Turns out we were ignoring versionId in manifest generation, which resulted in a) wrong metadata (current instead of version specific) b) wrong files in workspace (current instead of version specific). Sadly this was affecting functionalities like export and copyTale...

How to test?

  1. Depends on https://github.com/whole-tale/wt_versioning/pull/47
  2. Create a Tale, upload something to workspace.
  3. Create a version.
  4. Modify Tale's metadata (title, keywords, authors, or build it to get imageInfo) and workspace.
  5. Save a version.
  6. Export the first version. Confirm that manifest.json contains proper metadata. Confirm that workspace contains proper files
  7. Repeat 6. but copy the Tale from the first version instead, using "shallow=True".
codecov[bot] commented 1 year ago

Codecov Report

Merging #554 (6d8ac7e) into master (a2cbb8f) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   92.83%   92.86%   +0.03%     
==========================================
  Files          60       60              
  Lines        4770     4778       +8     
==========================================
+ Hits         4428     4437       +9     
+ Misses        342      341       -1
Impacted Files Coverage Δ
server/lib/manifest.py 93.30% <100.00%> (+0.21%) :arrow_up:
server/lib/manifest_parser.py 88.81% <0.00%> (+0.62%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.