whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

fix: prevent re-registration of external data files. Fixes #555 #556

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

During registration avoid any changes if an item has a file.

How to test

  1. Follow #555
  2. Confirm there are no duplicates.
codecov[bot] commented 1 year ago

Codecov Report

Base: 92.86% // Head: 92.86% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (0dbaffe) compared to base (ff31bf8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #556 +/- ## ======================================= Coverage 92.86% 92.86% ======================================= Files 60 60 Lines 4778 4782 +4 ======================================= + Hits 4437 4441 +4 Misses 341 341 ``` | [Impacted Files](https://codecov.io/gh/whole-tale/girder_wholetale/pull/556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale) | Coverage Δ | | |---|---|---| | [server/lib/import\_providers.py](https://codecov.io/gh/whole-tale/girder_wholetale/pull/556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale#diff-c2VydmVyL2xpYi9pbXBvcnRfcHJvdmlkZXJzLnB5) | `92.59% <100.00%> (+0.28%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Xarthisius commented 1 year ago

@craig-willis friendly review ping