Closed Xarthisius closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
master@fc1322e
). Click here to learn what that means. Patch coverage: 93.10% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Aimed at fixing https://github.com/whole-tale/whole-tale/issues/98
LGTM +1 this works as advertised!
I noticed that it returns a 500 error when the instance is still building/starting up.. I wonder if could this possibly be changed to a 503 in this case? that way, we could tell between when there is an error fetching the logs and when they will be available soon.
If this would be a really large change, then feel free to disregard.
I'll do that, but that belongs to another repo.
Allow to fetch instance logs via exposing
service.logs
. Custom http server to do that is available from here: https://github.com/whole-tale/instance_loggerHow to test?
Modify your local deploy-dev: