search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

fix: compute imageInfo dynamically based on workspace #558

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

During manifest creation compute imageInfo tag/image name using the state of workspace, rather than whatever is dangling off the Tale object.

craig-willis commented 1 year ago

See https://github.com/whole-tale/deploy-dev/pull/53#issuecomment-1282608947. If /tmp isn't mounted, run_r2d fails but the tag is still generated. In https://github.com/whole-tale/gwvolman/blob/master/gwvolman/build_utils.py#L222-L223 we log the error but still return the hash. Changing this to raise an exception works, but could also handle the return code in get_tag?