whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Handle canceling of chain jobs #565

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

Companion to https://github.com/whole-tale/gwvolman/pull/177

Adds 'canceled' state to notifications and fixes handling of chain task revocation.

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.81% // Head: 92.79% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (d4c4ee2) compared to base (dd50c40). Patch coverage: 84.21% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #565 +/- ## ========================================== - Coverage 92.81% 92.79% -0.02% ========================================== Files 61 61 Lines 4870 4887 +17 ========================================== + Hits 4520 4535 +15 - Misses 350 352 +2 ``` | [Impacted Files](https://codecov.io/gh/whole-tale/girder_wholetale/pull/565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale) | Coverage Δ | | |---|---|---| | [server/models/instance.py](https://codecov.io/gh/whole-tale/girder_wholetale/pull/565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale#diff-c2VydmVyL21vZGVscy9pbnN0YW5jZS5weQ==) | `86.26% <50.00%> (-0.82%)` | :arrow_down: | | [server/rest/tale.py](https://codecov.io/gh/whole-tale/girder_wholetale/pull/565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale#diff-c2VydmVyL3Jlc3QvdGFsZS5weQ==) | `96.59% <88.88%> (+0.08%)` | :arrow_up: | | [server/\_\_init\_\_.py](https://codecov.io/gh/whole-tale/girder_wholetale/pull/565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale#diff-c2VydmVyL19faW5pdF9fLnB5) | `91.00% <100.00%> (+0.12%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.