search

whole-tale / girder_wholetale

Girder plugin providing basic Whole Tale functionality
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Pass only parent as dataSet in AinWT from girder #576

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

Fixes an issue where content of directory is too big to be represented as query parameter. Downside is that it introduces another level in ../data/

How to test

  1. Create a collection with a folder test.
  2. Import some data (e.g. /girder/plugins/virtual_resources) to test
  3. Run AinWT from test
  4. Tale should be created with only a single entry in the dataSet (test).
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4266bc) 92.89% compared to head (a2a8ca3) 92.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #576 +/- ## ======================================= Coverage 92.89% 92.89% ======================================= Files 61 61 Lines 4971 4971 ======================================= Hits 4618 4618 Misses 353 353 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=whole-tale)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

craig-willis commented 1 year ago

Fixes an issue where content of directory is too big to be represented as query parameter. ... and that https://www.gw-openscience.org is now https://gwosc.org/

Looks good.

Purely cosmetic -- but what would it take to display the folder name instead of the folder ID? image

Xarthisius commented 1 year ago

Fixes an issue where content of directory is too big to be represented as query parameter. ... and that https://www.gw-openscience.org is now https://gwosc.org/

Looks good.

Purely cosmetic -- but what would it take to display the folder name instead of the folder ID?

Either passing it as a param, or making GET /folder/:id on the dashboard side.