whole-tale / ngx-dashboard

WholeTale Dashboard rewritten in Angular
MIT License
0 stars 3 forks source link

Enabling autofill suggestions #154

Open craig-willis opened 3 years ago

craig-willis commented 3 years ago

This is super minor, but I've noticed a few fields that seem to have browser autofill suggestions disabled. These are mostly noticeable during testing. I think it's related to the use of div class="field".

For example, the "Git Repository URL" on the "Create New Tale" modal supports autofill suggestions, but not the URL field on the "Connect to Git Repo" menu. Most fields on metadata edit support suggestions, but not the author names or ORCID. ORCID is one of the most noticeable to me.

bodom0015 commented 3 years ago

If you're referring to Chrome autofill, this used to have to do with the id or name on the form field. For commonly-recognized field names like "name" or "address", Chrome offered to autofill these things if it recognized where to pull the data from.

Apparently this changed back in 2015, and there is now an autocomplete="address-line1" attribute that can be added to hint to the browser what data to use (see https://developers.google.com/web/updates/2015/06/checkout-faster-with-autofill). While the autocomplete attribute appears to be supported in all modern browsers, I'm hoping that there are very few quirks between the major browser vendors' implementation of this feature.

I'm not sure how easy it will be to customize support for this, but we should make sure to at least try this out to see if it can remember custom/specific values like ORCID