search

whole-tale / ngx-dashboard

WholeTale Dashboard rewritten in Angular
MIT License
0 stars 3 forks source link

Disable export menu option if not writable #262

Closed craig-willis closed 2 years ago

craig-willis commented 2 years ago

See https://github.com/whole-tale/ngx-dashboard/issues/260 for test case

This PR simply disables the Export menu as we already do publish. Another option would be to prompt the user to copy the tale.

bodom0015 commented 2 years ago

Ahhh, I did not realize that write access was needed for export, since it is a read-only operation on the server. I agree with this change given the current behavior of the backend :+1:

That said, I'm curious - is there a reason why write access is required for the backend export? The user is technically not writing to the Tale itself, right?

craig-willis commented 2 years ago

An exported or published tale must have a version. When versioning was added, the export and publish operations create a version if not present, so the user currently needs write access. Possibly worth further discussion for a future release.