Closed bodom0015 closed 1 year ago
This is looking good. Can we hide the menu option when there isn't an instance? Currently the menu is there and does nothing.
@craig-willis absolutely :+1: good call!
I pushed a fix to hide "View Logs" if there's no instance or status indicates that it is not running
That works.
While testing your change I came across another minor issues. It looks like RStudio doesn't produce any logs during startup. When hitting instance/{id}/log
for a running RStudio tale, the response body has no content. The View Logs window shows "Fetching logs, please wait...".
@craig-willis this is a known issue with the build logs as well... we currently assume that an empty array of logs
messages means that we haven't fetched them yet.
If this is a case that we should support properly in the UI, I can try to put a "No logs found" message or similar there when it gets back a response that is empty?
That sounds reasonable to me.
Problem
There is no way to view the logs for a running Tale Instance from the WholeTale Dashboard.
Fixes #308
Approach
/instance/{id}/log
within theInstanceService
view-logs-dialog
to work not only with a list of Job ids, but also with an instance idInstance
resource asthis.data.instance
, the dialog will show the logs for that Instancethis.data.jobIds
to fetch/merge those logs accordinglyHow to Test
Prerequisites: pull from upstream for all source repos, at least one Tale created/launched