whole-tale / ngx-dashboard

WholeTale Dashboard rewritten in Angular
MIT License
0 stars 3 forks source link

feat: prompt for instance shutdown when Tale delete=409 #316

Open bodom0015 opened 1 year ago

bodom0015 commented 1 year ago

Problem

We now have the option to force deletion of Tale instances from the UI, but UI needs to handle the new force API parameter

Fixes #229

Approach

NOTE: there are two paths for this - the "Running Tales" section has its own handling that is separate from the rest of the page

Screen Shot 2022-12-19 at 1 29 45 PM

How to Test

Prerequisites: at least one Tale running that you own

  1. Checkout this branch locally, rebuild the dashboard
  2. Login to the WholeTale Dashboard
  3. Navigate to the Tale Catalog and find a Tale that you own
  4. Start the Tale, if you haven't already
    • You should be navigated to the Run Tale page
  5. Go back to the Tale Dashboard and click the X on the Tale to delete it
    • You should see the Delete Tale modal appear
  6. Confirm this modal and you should see a ConfirmationModal appear
    • You should see this modal warns you about running instances and the consequences for deleting them
  7. After confirming, you should see the Tale and Instances are now deleted