search

whole-tale / ngx-dashboard

WholeTale Dashboard rewritten in Angular
MIT License
0 stars 3 forks source link

fix: don't hardcode data catalog url #326

Closed Xarthisius closed 1 year ago

Xarthisius commented 1 year ago

Problem

Data catalog link is hardcoded

Approach

Use rootUrl to derive a proper link

Note Other seemingly unrelated changes were made to make linter happy...

How to Test

Prerequisites:

  1. Checkout this branch locally, rebuild the dashboard
  2. Enable Data Catalog
  3. Go to dashboard and check Data Catalog links to girder.