whole-tale / repo2docker_wholetale

Repo2docker plugin for Whole Tale
Other
0 stars 1 forks source link

Various fixes for supporting iframes running in external domains #38

Closed Xarthisius closed 2 years ago

Xarthisius commented 2 years ago

Fixes https://github.com/whole-tale/whole-tale/issues/108 (at least RStudio and Jupyter part, I haven't tried openrefine and matlab yet).

How to test

  1. Build local r2d_wt (or use xarthisius/repo2docker_wholetale:rsamesite)
  2. Ensure that you're running latest girder + you've set "core.secure_cookie" to true.
  3. Create a tale with "config.csp" equal to: "frame-ancestors 'self' https://dashboard.local.wholetale.org https://your.testsite"
  4. Run the Tale.
  5. Using your https://your.testsite embed Instance url in an iframe.
  6. Check all Images running jupyter and R.

In the latest deploy-dev change "dev_images.json" in https://github.com/whole-tale/deploy-dev/blob/master/setup_girder.py#L153 to "stage_images.json" to quickly get a bunch of different environments.

Xarthisius commented 2 years ago

R < 3.5.3 is now working as expected (clang is being installed).