search

whole-tale / repo2docker_wholetale

Repo2docker plugin for Whole Tale
Other
0 stars 1 forks source link

Port to latest upstream r2d #44

Closed Xarthisius closed 2 years ago

Xarthisius commented 2 years ago

In theory this PR will allow us to run almost vanilla repo2docker (only change that remains is setting mran to last quarter rather than "3 days ago"). You can test this by building it with xarthisius/repo2docker:latest (which is based on https://github.com/whole-tale/repo2docker/tree/updated_from_main)

NOTE: You need to patch gwvolman to use our new engine:

diff --git a/gwvolman/build_utils.py b/gwvolman/build_utils.py
index 24364b1..2e1a045 100644
--- a/gwvolman/build_utils.py
+++ b/gwvolman/build_utils.py
@@ -167,6 +167,7 @@ class ImageBuilder:
         target_repo_dir = os.path.join(self.container_config.target_mount, "workspace")
         r2d_cmd = (
             "jupyter-repo2docker "
+            "--engine dockercli "
             "--config='/wholetale/repo2docker_config.py' "
             f"--target-repo-dir='{target_repo_dir}' "
             f"--user-id=1000 --user-name={self.container_config.container_user} "