Testing ngx-dashboard (@4aba79c, MacOS/Chrome)

[craig-willis]

https://github.com/whole-tale/ngx-dashboard/commit/4aba79cf76f31bd4ee1b18a3dc29d00509300444

Test Plan

Preconditions:

• Clear browsing history or open incognito/private session
• Disconnect all third party integrations

Authentication

• [x] Basic login flow

  1. Goto https://dashboard.local.wholetale.org
  2. Select "Access Whole Tale" button. You should be prompted to login via Globus Auth.
  3. Select your organization and login
  4. You should be taken to the Browse page
  5. Your Gravatar and user name should display

• [x] Basic logout flow

  1. Select the "User" menu
  2. Select the "Log out" menu item. You should be taken to the login page.
  3. Select "Access Whole Tale" button.
  4. Note that you are not prompted to login.
  5. Note issue #384 for logout for Globus
  6. Restart your incognito session
  7. Select "Access Whole Tale" button. You should be prompted to login via Globus Auth.

• [x] Return-route for non-logged in users (#300)

  1. Logout from Whole Tale
  2. Attempt to access https://dashboard.local.wholetale.org/manage
  3. You should be redirected to https://dashboard.local.wholetale.org/login?rd=%252Fmanage
  4. Select "Access Whole Tale".
  5. You should be redirected to the Manage page.

Navigation

• [ ] General navigation
  1. Select "Browse" button. Browse page should display
  2. Click "Create New..." and choose "Create new Tale". Create Tale modal should display, then close the modal.
  3. Select "Manage" button. Manage page should display
  4. Select "i" button should open User Guide in new tab
  5. Select "Notification" button should display the notification panel
  6. Select "Report a problem" button should open https://github.com/whole-tale/whole-tale/issues in new tab
  7. Select "View" on a Tale. The Run page should display
  8. Click the "user" icon
     • You should see a dropdown expand
     • The dropdown should contain the user's first/last name and gravatar image
     • The dropdown should provide a link to the Settings page
     • The dropdown should provide an option to Logout
     • Select the "Settings" option should bring you to the Settings page

Browse

Preconditions:

• Assumes production Tales present (e.g., LIGO, materials, etc).

• No running instances

• [x] General

  1. Select "Browse" button. Confirm browse page displays
  2. Confirm that no Tales are running

• [ ] Search

  1. Enter "Ligo" as search term. Confirm only LIGO tale displays
  2. Clear search term. Confirm all tales display

• [ ] Filter

  1. Navigate to the Browse page
  2. Confirm that you can switch between "All Tales" and "My Tales"
  3. Confirm that all public Tales are shown on "All Tales"
  4. Confirm that your Tales are shown under "My Tales"
  5. Select "My Tales"
  6. View a Tale and then navigate back to Browse
  7. Confirm the filter is not reset

• [ ] View tale

  1. Select "View" button on LIGO Tale
  2. Confirm that Run > Metadata page displays
  3. Confirm that you cannot delete or edit Tale properties
  4. Select Back button. Confirm that you are taken back to Browse page
  5. Select "View" button on Tale you own
  6. Confirm that the Run and Close buttons are present
  7. Confirm that you can edit Tale properties
  8. Select "Close"
  9. Confirm that you are taken back to Browse

• [ ] Launch instance

  1. Select "Run Tale" button on "Ligo" tale
  2. Confirm you are prompted to Copy and Run
  3. Select Copy and Run
  4. Confirm that you are redirected to the Tale's Run page
  5. Confirm that the notification dialog appears
  6. Confirm that the step progression is correct
  7. Confirm that the "View Logs" button shows the build logs in a modal
  8. Navigate to the Browse page
  9. Confirm that the Tale is shown under "Currently Running"
  10. Select "View" on the Tale card
  11. Select "Stop" to end the Tale instance
  12. Confirm that the Tale has stopped
  13. Confirm that the button has changed to Run
  14. Navigate to Browse
  15. Confirm that there are no Tales under "Currently Running"
  16. Select the "Run Tale" button on a Tale you own
  17. After the instance is launched, navigate back to the Browse page
  18. Try to delete the Tale (not instance)
  19. Confirm you cannot select the delete button on the browse page
  20. Confirm that the "Run Tale" button has been replaced with "Stop Tale"
  21. Confirm that the Tale is shown at the top of the page under "Currently running"

Manage

Preconditions

• Empty home directory

• No registered data

• [ ] Register General

  1. Select Manage > Data > "+" to open register panel
  2. Confirm list of providers matches list of supported providers (Globus, DataONE, Dataverse, Zenodo)

• [ ] Register DataONE data

  1. Select Manage > Data tab
  2. Select "+". Confirm "Search for Data Sources" modal displays
  3. Search for DOI 10.5065/D6862DM8
  4. Confirm "Humans and Hydrology" dataset is found on DataONE.
  5. Select Register
  6. Confirm dataset appears in Manage Data list
  7. Confirm additional URL formats:
  8. https://search.dataone.org/view/doi:10.5063/F1Z60M87
  9. https://search.dataone.org/view/https://pasta.lternet.edu/package/metadata/eml/knb-lter-nwt/115/1
  10. https://search.dataone.org/view/doi:10.18739/A2CN6XZ7H
  11. https://raw.githubusercontent.com/whole-tale/dashboard/master/.travis.yml

• [ ] Dataverse

  1. Register dataset doi:10.7910/DVN/SZ9YXZ
  2. Confirm "Replication Data for: Direct Democracy and Women's Political Engagement" from Dataverse

• [ ] Globus/MDF

  1. Confirm DOI resolution for http://dx.doi.org/doi:10.18126/M2301J results in https://petreldata.net/mdf/detail/pub_30_shahani_twinmediated_v1.2
  2. Register dataset https://petreldata.net/mdf/detail/pub_30_shahani_twinmediated_v1.2

Run

Preconditions:

• No running Tale instances

• [ ] General

  1. Launch (Copy and Run) the Ligo Tale and wait for instance to start
  2. Confirm you are on the Run page
  3. Confirm Run panel displays Tale icon, title, and author
  4. Confirm Run page displays Interact, Files, Metadata tabs
  5. Select "..." menu.
  6. "Learn more" displays https://wholetale.readthedocs.io/en/stable/users_guide/run.html
  7. Confirm fullscreen displays Run panel in full screen
  8. Confirm that the option for exporting the Tale is present

• [ ] Interact tab

  1. Select the "Interact" tab
  2. Confirm Jupyter environment is displayed in iframe
  3. Select "popout" icon. Confirm Jupyter is opened in new Tab

• [ ] Files tab

  1. Select "Files" tab
  2. You should see a vertical navigation menu with three tabs: "Home", "External Data", and "Tale Workspace".

• [ ] Metadata tab - Owned Tale

  1. Launch a Tale that you own
  2. Add multiple datasets that have DOIs to the Tale
  3. Navigate to Run > metadata
  4. Valid environments should be listed in the Environment dropdown menu
  5. Valid licenses should be listed in the License dropdown
  6. Confirm that you see Created by <your_name> under Authors
  7. Confirm that your Tale has the CC4 license assigned to it
  8. Confirm that the Tale's Published Location reads This Tale has not been published
  9. Confirm that there are citations for the external datasets
  10. Change the name of the Tale, Category, Description, Illustration, Public, License, and add multiple authors
  11. Select Save. Confirm that you see a notification telling you that the Tale was saved.
  12. Refresh the page. Your changes should be preserved between page refreshes, confirming that they are being properly persisted.
  13. Confirm that the new Tale authors are displayed on the Tale card

• [ ] Home

  1. Select Files > Home. Confirm that your home directory displays
  2. Create a folder and upload a file to the folder
  3. Confirm file operations:
  4. Copy, rename, remove, download, Move To...

• [ ] External data

  1. Precondition: Register one or more Datasets (e.g. doi:10.18739/A29G5GD0V) on Manage > Data (see Manage > Register test cases above)
     • NOTE: You may need to wait for registration to complete
  2. Confirm "External Data" list is initially empty
  3. Confirm (+) button ("Select Data modal") behavior
  4. Confirm that "WholeTale Catalog" shows all registered datasets
  5. Confirm that "My Data" filters to only show your registered datasets
  6. "Add" data to associate it with a Tale
  7. "Remove" data to dissociate it with a Tale
  8. "Select" saves your changes back to the server
  9. "Cancel" aborts the operation without saving and reverts your changes
  10. Confirm "External Data" list matches what was saved

• [ ] Workspaces

  1. Confirm create folder
  2. Confirm upload file
  3. Select "+" button has options "New folder", "Upload file", Import Tale Data..."
  4. Folder operations
  5. Confirm context menu Copy, Rename, Download, Remove
  6. Confirm rename folder
  7. Confirm download folder (this should result in a zip file)
  8. Confirm remove folder
  9. File operations
  10. Upload a file
  11. Confirm context menu Copy, Rename, Download, Remove
  12. Confirm rename folder
  13. Confirm download file
  14. Confirm remove file
  15. Select "Import Tale Data..."
  16. Note vertical navigation with Tale Workspaces
  17. Copy to Workspace from another workspace
  18. Move to workspace from another workspace

• [ ] Exporting - BagIt

  1. View a Tale that you own
  2. Navigate to Run
  3. Click the three-dot-dropdown
  4. Select 'Export as BagIt'
  5. Confirm that a download starts for the ZIP archive
  6. Open the archive
  7. Confirm that the top level has
  8. run-local.sh
  9. tagmanifest-sha256.txt
  10. tagmanifest-md5.txt
  11. manifest-sha256.txt
  12. manifest-md5.txt
  13. bag-info.txt
  14. README.md
  15. bagit.txt
  16. fetch.txt
  17. data/
  18. metadata/
  19. Navigate into the metadata folder
  20. Confirm that there is a manifest.json and environment.json file
  21. Navigate to /data
  22. Confirm that there is a LICENSE file

Settings

• [ ] Default State

  1. Navigate to the Settings page
  2. Confirm there are empty settings for DataONE, Dataverse, and Zenodo

• [ ] Connect to DataONE

  1. Click "Connect Account" under the DataONE repository
  2. Confirm that you're redirected to the DataONE login
  3. Log in with ORCID
  4. Confirm that you're redirected back to Whole Tale
  5. Confirm that you see "Authorized" under the DataONE server
  6. Confirm that the "Connect Account" Button is disabled
  7. Disconnect your account
  8. Confirm that you can re-connect it

• [ ] Connect to Dataverse

  1. Click "Connect Account" in the Dataverse section
  2. Confirm that the connection modal opens
  3. Enter your API key for one of the repositories
  4. Click "Connect"
  5. Confirm that you see "Authorized on "
  6. Repeat for each Dataverse server

• [ ] Connect to Zenodo

  1. Click "Connect Account" in the Zenodo section
  2. Confirm that the connection modal opens
  3. Enter your API key for one of the repositories
  4. Click "Connect"
  5. Confirm that you see "Authorized on "
  6. Repeat for each Zenodo server

• [ ] Confirm tokens retained across logins #370

  1. Connect one or more accounts as outlined above
  2. Logout and login again
  3. Using Swagger UI, hit the /user/me endpoint to confirm tokens are still present

Tale Creation

• [ ] Create RStudio Tale

  1. Select the Create New... button on the Browse Page
  2. Select the Create New Tale dropdown item
  3. Enter title "Test Tale"
  4. Select compute environment RStudio
  5. Select "Create New Tale and Launch"
  6. Confirm notification dialog opens
  7. Confirm that the build/launch steps are correct
  8. Confirm that you are redirected to the Run page
  9. Navigate to the Browse page
  10. Confirm the Tale is shown under "Currently running"

• [ ] Compose Jupyter Tale

• [ ] Compose OpenRefine Tale

• [ ] Too many instances

  1. Make sure you have two launched Tales
  2. Attempt to create a Tale
  3. Confirm that you receive an error that you have the max limit
  4. Confirm that the Tale is created, but not the instance

Analyze in Whole Tale

Task 1: Importing a Dataset from Dataverse

These test cases cover potential situations that can occur when importing datasets from Dataverse.

• [ ] Case 1: Ideal Scenario:

Testing Steps:

1. Remove all running Tale instances
2. Navigate to https://girder.local.wholetale.org/api/v1/integration/dataverse?datasetPid=doi%3A10.7910%2FDVN%2F3MJ7IR&siteUrl=https%3A%2F%2Fdataverse.harvard.edu
3. Confirm that the Tale title reads as Replication Data for: "Agricultural Fires and Health at Birth"
4. Confirm that the only item in the Input data section matches the uri with Data Source appended
5. Confirm that no environment is selected
6. Confirm that the Create New Tale and Launch button is disabled
7. Select an environment
8. Confirm that READ/WRITE is selected
9. Click Create New Tale and Launch
10. Confirm that you are redirected to the run page
11. Confirm that the Tale name matches the Tale Name in the Create Tale Modal
12. Confirm that the data exists under Tale Workspace
13. Confirm that the Tale's category is science

Task 2: Importing a Dataset from DataONE

These test cases cover different scenarios that may happen when importing datasets from DataONE.

• [ ] Case 1: Ideal Scenario:

This test covers the ideal case where dataset importing has all of the needed information to properly run. This includes the dataset location, title, and selected environment.

Testing Steps:

1. Remove all running Tale instances
2. Navigate to https://girder.local.wholetale.org/api/v1/integration/dataone?uri=https%3A%2F%2Fsearch.dataone.org%2Fview%2Fdoi%3A10.18739%2FA2VQ2S94D&title=Fire%20influences%20on%20forest%20recovery%20and%20associated%20climate%20feedbacks%20in%20Siberian%20Larch%20Forests%2C%20Russia&environment=RStudio
3. Confirm that the Tale title reads as Fire influences on forest recovery and associated climate feedbacks in Siberian Larch Forests, Russia
4. Confirm that the only item in the Selected data section matches the uri with Data Source appended
5. Confirm that Rstudio is selected in the Environments widget
6. Confirm that the Create New Tale and Launch button is enabled
7. Confirm READ ONLY is selected
8. Click Create New Tale and Launch
9. Confirm that you are redirected to the run page
10. Confirm that the Tale name matches the Tale Name in the Create Tale Modal
11. Confirm that the data exists in the Tale under External Data
12. Confirm that the Tale's category is science

• [ ] Case 2: Testing Different DataONE Deployments The Analyze in Whole Tale feature is deployed across a few DataONE test sites. This test ensures Whole Tale has the ability to import data from each of them.

Links:

1. https://dashboard.local.wholetale.org/browse?api=https%3A%2F%2Fcn-stage-2.test.dataone.org%2Fcn%2Fv2&name=Dataone%20Dataset&uri=https://dev.nceas.ucsb.edu/view/doi:10.5072/FK2K075M25
2. https://dashboard.local.wholetale.org/browse?api=http%3A%2F%2Fcn-stage.test.dataone.org%2Fcn%2Fv2&name=Dataone%20Dataset&uri=https://test.arcticdata.io/view/doi:10.5065/D6N014NC

Testing Steps:

1. Remove all running Tale instances
2. Navigate to each of the two links above
3. Select an environment
4. Click Create New Tale and Launch
5. Confirm that the correct data exists in the Tale under External Data

Task 3: Shared Behavior

These cases show errors that are common between Dataverse and DataONE. Although they are tested using DataONE URIs, the errors should be the same when replacing it with a Dataverse URI.

• [ ] Case 1: Missing Dataset Title Query Param:

This test covers the case where the name query parameter is missing. The expected behavior is that the uri query parameter is used instead.

Testing Steps:

1. Remove all running Tale instances
2. Navigate to https://dashboard.local.wholetale.org/browse?uri=https%3A%2F%2Fdataverse.harvard.edu%2Fapi%2Faccess%2Fdatafile%2F3323458
3. Confirm that the Tale title reads as https://dataverse.harvard.edu/api/access/datafile/3323458
4. Confirm that the only item in the Selected data section matches the uri with Data Source appended
5. Confirm that no Environment is selected
6. Confirm that the Create New Tale and Launch button is disabled
7. Select an environment
8. Click Create New Tale and Launch
9. Confirm that the notification bar appears & properly updates
10. Confirm that you are redirected to the run page
11. Confirm that the Tale name matches the Tale Name in the Create Tale Modal
12. Confirm that the data exists in the Tale under External Data

• [ ] Case 2: Importing Data with Read/Write:

This test covers the case where a user imports data from an external source and selects READ/WRITE in the Create Tale Modal.

Testing Steps (Variant 1):

1. Remove all running Tale instances
2. Navigate to https://dashboard.local.wholetale.org/browse?uri=https%3A%2F%2Fdataverse.harvard.edu%2Fapi%2Faccess%2Fdatafile%2F3323458
3. Confirm that the Tale title matches the URI above
4. Confirm that the only item in the Selected data section matches the uri with Data Source appended
5. Confirm that the Create New Tale and Launch button is disabled
6. Select an environment
7. Select READ/WRITE
8. Click Create New Tale and Launch
9. Confirm that the notification bar appears & properly updates
10. Confirm that you are redirected to the run page
11. Confirm that the Tale name matches the Tale Name in the Create Tale Modal
12. Confirm that the data exists in the Tale Workspace

Testing Steps (Variant 2):

1. Remove all running Tale instances
2. Navigate to https://dashboard.local.wholetale.org/browse?api=https%3A%2F%2Fdev.nceas.ucsb.edu%2Fknb%2Fd1%2Fmn%2Fv2&environment=JupyterLab&name=proveit&uri=doi%3A10.5072%2FFK27P92Z55
3. Confirm that the Tale title matches the dataset
4. Confirm that the only item in the Selected data section matches the uri with Data Source appended
5. Confirm that the Create New Tale and Launch button is disabled
6. Select READ/WRITE
7. Click Create New Tale and Launch
8. Confirm that the notification bar appears & properly updates
9. Confirm that you are redirected to the run page
10. Confirm that the Tale name matches the Tale Name in the Create Tale Modal
11. Confirm that the data exists in the Tale Workspace

Tale metadata tests

The purpose of these tests are to confirm that the metadata files (manifest.json, environment.json, LICENSE) we generate are correct.

• [ ] manifest.json

  1. Launch a Tale that you own
  2. Add a dataset to the Tale
  3. Add at least one author
  4. Add at least one file to the workspace
  5. Export the Tale (as BagIt)
  6. Open the manifest.json file under metadata/
  7. Confirm that the author is listed under schema:author
  8. Confirm that you are listed under createdBy
  9. Confirm that the file(s) in the workspace are properly listed in aggregates
  10. Confirm that the external dataset is referenced in aggregates
  11. Confirm that the dataset is also listed under Datasets

• [ ] environment.json

  1. Open the archive from the manifest.json test
  2. Navigate to metadata/environment.json
  3. Open the girder web API
  4. Locate and GET the Image that the Tale used
  5. Confirm that the config section from girder matches the config section in environment.json

• [ ] LICENSE

  1. Open the archive from the manifest.json test
  2. Open the LICENSE file
  3. Navigate to Run > metadata
  4. Confirm that the opened LICENSE file matches the selected license on the metadata page
  5. Change the Tale's license
  6. Export the Tale
  7. Confirm that the LICENSE changed appropriately

Publishing tests

• [ ] Case 1: No Accounts Configured

  1. Disconnect all of your external accounts
  2. Launch a Tale that you own
  3. Click the ellipsis dropdown on the Run page
  4. Click Publish tale...
  5. Confirm that your are notified to link accounts on the settings page
  6. Click Go to Settings
  7. Confirm you are re-directed to settings

• [ ] Case 2: Publishing to a Third Party

  1. Connect to a third party provider (make sure it's a dev server)
  2. Launch a Tale that you own
  3. Add some data to it
  4. Click Publish tale...
  5. Confirm that the publishing modal opens
  6. Confirm that the third party that you are connected to appears in the dropdown
  7. Select the third party
  8. Click Publish
  9. Once complete, navigate to the metadata page
  10. Confirm that the published location is present
  11. Visit the published location
  12. Confirm that you see the following files plus yours
      1. metadata.xml
      2. LICENSE
      3. README.md
      4. manifest.json
      5. environment.json

  13. Repeat for each third party provider

      a. After publishing to DataONE, use girder to query the Tale

      b. Ensure that the 'pid' field in the 'publishInfo' object has an identifier in a doi format

• [ ] Case 3: Re-published Tale

  1. Launch a Tale that has been published before
  2. Take note of the Published Location in Run > metadata
  3. Re-publish the Tale to the third party
  4. Confirm that the Published Location has changed to the correct package landing page

Zenodo integration tests

• [ ] Register Zenodo data
  1. Select Manage > Data tab
  2. Select "+". Confirm "Search for Data Sources" modal displays
  3. Search for Concept DOI doi:10.5281/zenodo.16384
  4. Confirm "Belmont Forum..." dataset is found on Zenodo with suffix ver_1
  5. Search for URL https://zenodo.org/record/1172960#.XidIvlNKh24
  6. Confirm "Belmont Forum..." dataset is found on Zenodo with suffix ver_2
  7. Search for DOI doi:10.5281/zenodo.1172960
  8. Confirm "Belmont Forum..." dataset is found on Zenodo with suffix ver_2
  9. Search for Concept DOI doi:10.5281/zenodo.608984
  10. Confirm "Belmont Forum..." dataset is found on Zenodo with suffix ver_2
  11. Select Register
  12. Confirm dataset appears in Manage Data list
  13. Add to tale and confirm contents match

The register tests the following cases.

• Datasets with multiple files
• Datasets with multiple versions
• Concept DOI

• [ ] Zenodo dataset via AiWT
  1. Open https://dashboard.local.wholetale.org/browse?uri=https%3A%2F%2Fdoi.org%2F10.5281%2Fzenodo.820575&name=Automotive%20Sensor%20Data
  2. Confirm Source Data URL and Title match above URL and "READ ONLY" is selected
  3. Select environment
  4. Select 'Create and Launch Tale'
  5. Confirm dataset is mounted read-only, citation is as expected, zipfile is not extracted

The register tests the following cases.

• Dataset with single file (zipfile)

• [ ] Zenodo Binder via AiWT

1. Open https://dashboard.local.wholetale.org/browse?uri=https%3A%2F%2Fdoi.org%2F10.5281%2Fzenodo.3242073&environment=JupyterLab&name=Simple%20requirements.txt%20based%20example%20for%20repo2docker&asTale=true
2. COnfirm Source Data and Title match URL and "READ WRITE" is selected
3. Select 'Create and Launch Tale'
4. Confirm image builds and notebook can run

• [ ] Zenodo Tale via AiWT

1. Open https://girder.local.wholetale.org/api/v1/integration/zenodo?doi=10.5072%2Fzenodo.490450&resource_server=sandbox.zenodo.org
2. Confirm Water Tale is created.
3. Confirm citation on Metadata view
4. Confirm DOI matches above
5. Use the Swagger UI to confirm the publishInfo field on the tale object contains pid, repository, repository_id, uri
6. Run the tale and and notebook, confirm it works as expected (produces glorious map of Texas)

• [ ] Publish/import to/from Zenodo Sandbox
  1. Follow instructions above to configure your API key for Zenodo sandbox
  2. Create your own Tale and publish to sandbox.zenodo.org
  3. Confirm publishInfo contains Sandbox entry
  4. Delete tale
  5. Import tale from Zenodo
  6. Confirm publishInfo
  7. Modify the tale
  8. Re-publish to sandbox.zenodo.org
  9. Delete tale
  10. Import tale from Zenodo
  11. Confirm publishInfo
  12. Download and extract the exported Tale
  13. Execute the run-local.sh command to run the Tale locally

Regression tests

• [ ] Internal-state problems (#326)

  1. Open a non-incognito browser tab, log into the UI and navigate to the /manage view
  2. Create a folder (e.g. test123) and click down into it
  3. Open an incognito browser tab, login to the UI again, and navigate to the /manage view
  4. In the incognito tab, delete the test123 folder and close the incognito tab
  5. Refresh your non-incognito browser tab
  6. You should not be stuck on a blue screen
  7. You should not need to manually refresh the page
  8. You should be taken to the /manage view of your Home folder
  9. NOTE: Your last refresh may take a couple of seconds longer than usual

• [ ] Invalid instance ID (#333)

  1. Manually change the path suffix in the address bar to /run/ThisIsObviouslyNotARealID
  2. You should be brought to /browse page instead

• [ ] Files don't overflow Manage page (#410)

  1. Navigate to the manage page
  2. Register enough/upload enough data to the point where you need to scroll through files on the right hand side
  3. Make sure that the files don't overflow the container, also check in Firefox

• [ ] Handle read only Tales (#406)

  1. Login to the WholeTale Dashboard
  2. View a Tale that allows you to read, but not write
  3. Navigate to Run > Files > Tale Workspaces
     • You should see the Tale's Workspace folders/files are listed here
     • You should see that (+) has been greyed out, disallowing writes
  4. Navigate to Run > Files > External Data
     • You should see the Tale's External Datasets are listed here
     • You should see that (+) has been greyed out, disallowing writes