whole-tale / wt_home_dirs

0 stars 1 forks source link

Add integration with Girder WT plugin #1

Closed Xarthisius closed 6 years ago

Xarthisius commented 6 years ago

Enables two way integration between Girder and WT Home directory. Requires current master (https://github.com/whole-tale/girder/commit/91e295d9eefec2e152f23036578c8b402c60dfe3), adding tests and a bit of refactoring. Otherwise, it's a working proof-of-concept. @hategan PTAL

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5c9e573). Click here to learn what that means. The diff coverage is 80.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   71.35%           
=========================================
  Files             ?        8           
  Lines             ?      370           
  Branches          ?        0           
=========================================
  Hits              ?      264           
  Misses            ?      106           
  Partials          ?        0
Impacted Files Coverage Δ
server/constants.py 100% <ø> (ø)
server/models/password.py 36.2% <ø> (ø)
server/lib/DirectoryInitializer.py 94.11% <ø> (ø)
server/lib/Authorizer.py 64.86% <ø> (ø)
server/resources/homedirpass.py 61.11% <ø> (ø)
server/lib/WTDomainController.py 69.35% <50%> (ø)
server/lib/WTFilesystemProvider.py 77.86% <74.62%> (ø)
server/__init__.py 96.29% <96.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c9e573...08f0d07. Read the comment docs.

hategan commented 6 years ago

Looks good to me