whole-tale / wt_home_dirs

0 stars 1 forks source link

Updating `wthome.{home,tale}dir_root` doesn't update the `root` of an assetstore. #28

Closed Xarthisius closed 4 years ago

Xarthisius commented 4 years ago

Step to reproduce

  1. Deploy locally
  2. Navigate to https://girder.local.wholetale.org/#plugins/wt_home_dir/config
  3. Change root directories, click "Save".
  4. Navigate to https://girder.local.wholetale.org/api/v1#!/assetstore/assetstore_find , click "Try it out!"

Expected results

root in assetstore is updated

Actual results

root is set to default/previous value.

Xarthisius commented 4 years ago

I noticed it updates after restart. Maybe that's safer, cause I don't know if webdav can handle it otherwise...

hategan commented 4 years ago

That's intentional (for performance and code simplicity reasons)