search

whoownsphilly / wop-web

https://wop-web.vercel.app
2 stars 1 forks source link

Code violations date data cleaning: Some dates too far back #37

Open dcaud opened 3 years ago

dcaud commented 3 years ago

Example?

DHorks commented 3 years ago

See: http://phillydb-web.herokuapp.com/#/owner/REGAN%20GERARD

Date starts at 1920 image

Could be a data cleanup issue, if this is common maybe the earliest date should be set more recent?

dcaud commented 3 years ago

I gave this the V2 milestone, because I'm thinking it isn't essential for V1. Feel free to change if you think this need to be changed for V1.

ssuffian commented 3 years ago

The reason this happens is because of the problem with the deeds table. It only goes back to 2000. So the logic that I have for this ownership timeline is that it assumes whoever owned it in 2000 owned it since the "year_built_estimate" field. As indicated, its a rough estimate of when the year was built in the property assessment table, so it can likely be wrong - so we could add some logic to use "year_built" and then if its an estimate pick an "earliest year built" sort of minimum.