whoownsphilly / wop-web

https://wop-web.vercel.app
2 stars 1 forks source link

No results (or error message) for some addresses #57

Open dcaud opened 3 years ago

dcaud commented 3 years ago

I typed "250 East Johnson Street 19" into the search bar and for over a minute the processing circle animation spun around but no results ever showed up.

Ideally this would match to "250 E Johnson St", but maybe there should also be a timeout (after say 20 seconds?) that displays an error message like "No results found. Try re-formatting the address according to these examples." And hyperlink these examples to the address formatting page.

dcaud commented 3 years ago

Here's another example of something that returns no results: "1200 Callowhill"

ssuffian commented 3 years ago

I tried really hard and this is actually far more complicated than I thought. The searchbar uses semantic-ui-vue SearchBar and I can't for the life of me figure out how to make a 'watch' for the internal component in that (filteredResults is the name of the prop) that contains the number of results in the dropdown. It also has some sort of internal "no results" thing that I also can't figure out how to implement.