search

whoownsphilly / wop-web

https://wop-web.vercel.app
2 stars 1 forks source link

"Top 5 most common..." sections say "Loading..." #62

Closed dcaud closed 3 years ago

dcaud commented 3 years ago

For example, see https://phillydb-web.herokuapp.com/#/property/372097900

dcaud commented 3 years ago

The info loads on this page, albeit still after ~ 5 seconds: https://phillydb-web.herokuapp.com/#/property/312178600

My guess is that it is just extremely slow on the pages for properties with lots of connected possible owners.

ssuffian commented 3 years ago

Yep! I didn't want to wait for the whole page to have to load to just get that piece of information, so I put just the word "loading..." for now. We can make it nicer looking later - like have it as its own little box with a rotating loading screen or something. It's a pretty complex query because it has to download the full violations/complaints for all properties attached to all owners, and then filter them in-memory to get down to only the ones that occurred when the owners owned those properties.

dcaud commented 3 years ago

That makes sense. I wonder what to do for V1. The easy thing to do would be to remove it, I presume. I think it is mildly important to either have real data or remove it for V1. I don't know what to do!