Missing Version number in latest release

whoozle / android-file-transfer-linux

Android File Transfer for Linux (and macOS!)

http://whoozle.github.io/android-file-transfer-linux/

GNU Lesser General Public License v2.1

1.47k stars 120 forks source link

Missing Version number in latest release #262

Open suschizu opened 3 years ago

suschizu commented 3 years ago

Hey @whoozle - I just noticed that the version number is missing in the 4.2 mac download (https://github.com/whoozle/android-file-transfer-linux/releases/download/v4.2/AndroidFileTransferForLinux.dmg)

core-code commented 3 years ago

i can confirm this. both the CFBundleVersion and CFBundleShortVersion entries are missing from the Info.plist file

core-code commented 3 years ago

this is a regression. version 4.0 did contain the CFBundleVersion

yurikoles commented 9 months ago

I also confirm this.

yurikoles commented 9 months ago

https://developer.apple.com/library/archive/qa/qa1827/_index.html

suschizu commented 9 months ago

Version 4.3 again doesn't contain a version number :(

whoozle commented 9 months ago

Can you check the latest contiguous release? If it works for you, I'll release new version soon

yurikoles commented 9 months ago

It's fixed now, thanks! android-fle-transfer-linux-4 4

whoozle commented 9 months ago

Awesome, thanks for the fast reply!

This was something plaguing macosx builds for quite some time, I even refactored old plist into cmake-based one at some point, but overlooked that version variables were named differently than in the root cmake file :scream:

core-code commented 9 months ago

thanks for the progress here!

just FYI if you are already working on it the Get Info String (CFBundleGetInfoString) has been deprecated for ~15 years and should be removed. if you want to add copyright info the NSHumanReadableCopyright is the right place

whoozle commented 9 months ago

removed in f20e240c65ca6a8662e0106841d637d334a21e10 thanks :)

Can you take a look at https://github.com/whoozle/android-file-transfer-linux/blob/master/qt/Info.plist.in Maybe you can spot something obvious

core-code commented 9 months ago

basically looks good.

CFBundleLongVersionString

i think that one has been deprecated even back when Mac OS X was first released in 2001, so you can definitely drop it.

CFBundleDisplayName Android File Transfer for Linux and MacOSX

that changes the name under which the app shows up in the Finder so i'd recommend shortening it to 'Android File Transfer'.

if you really want to include the OSes it runs on (why?),"MacOSX" should be changed to "macOS" to match the official name these days.