search

whosonfirst-data / whosonfirst-data-admin-au

Whos On First admin data for AU, homepage: https://whosonfirst.org
Other
3 stars 5 forks source link

#2004 -Data hierarchy missing for Yarrabilba, QLD, AU - Add-wof-1779794981 #38

Closed pravink closed 2 years ago

pravink commented 2 years ago

Fixes https://github.com/whosonfirst-data/whosonfirst-data/issues/2004

Hi @stepps00

could you please review this PR for a new wof record for Yarrabilba.

Below are the document blocks which needs a careful attention as I was unsure on how to populate this data. "**wd:wordcount**":157, "**wof:belongsto**":[ 85681463, 102191583, 85632793, 136253039, 102048451 ], "wof:breaches":[], "**wof:concordances**":{ "fct:id":"0348a1d4-8f76-11e1-848f-cfd5bf3ef515", "gn:id":8348253, "gp:id":1101513, "qs_pg:id":1159507, "wd:id":"Q16890779" }, "wof:country":"AU", **"wof:geomhash"**:"dda4bc31ce578e81309bc447aedbced6",

and

"**wof:parent_id**":102048451, "wof:placetype":"locality", "wof:repo":"whosonfirst-data-admin-au", "wof:superseded_by":[], "**wof:supersedes**":[ 1126061583 ],

Thanks, Pravin!

stepps00 commented 2 years ago

This is great, thanks @pravink

I can actually take care if it from here - there are a few steps to validate these changes before it can be merged.. and I'll fix these properties as part of that validation.

stepps00 commented 2 years ago

I'm going to close this in preference of https://github.com/whosonfirst-data/whosonfirst-data-admin-au/pull/39 I've moved your commit to that PR.. to confirm, where did you source this polygon? We'll need to update the source for this geometry. Thanks!

pravink commented 2 years ago

I got it from ABS data AdminBounds_GDA94 - https://data.gov.au/dataset/ds-dga-bdcf5b09-89bc-47ec-9281-6b8e9ee147aa