whosonfirst-data / whosonfirst-data-admin-au

Whos On First admin data for AU, homepage: https://whosonfirst.org
Other
3 stars 5 forks source link

Update Place Wellington #46

Closed nvkelso closed 5 months ago

nvkelso commented 5 months ago

Updating data/101/932/275/101932275.geojson using the WOF Editor

nvkelso commented 5 months ago

Move NE props and related zoom props from AU record to NZ record, paired with https://github.com/whosonfirst-data/whosonfirst-data-admin-nz/pull/23

stepps00 commented 5 months ago

LGTM, though iirc the extra carriage returns at the end of records have caused problems with distributions / validation in the past. Changes look good but I'd recommend exportifying the record before merging.

stepps00 commented 5 months ago

False alarm - it looks like the newer Go exportify tools also add a carriage return at the end of a record. Some recent PRs that have updated WOF records using the Go tools have been merged, none have caused issue.. so tldr: this can be merged as-is.