search

whosonfirst-data / whosonfirst-data-admin-fr

Whos On First admin data for FR, homepage: https://whosonfirst.org
Other
0 stars 7 forks source link

Fix Catteville hierarchy and Petit-Caux name #17

Closed Joxit closed 11 months ago

Joxit commented 5 years ago

Hello,

I found some missing hierarchy for two localities names Catteville. And for 404426875, Berneval-Le-Grand is the name of one of the old localities that was merged to form Petit-Caux. So the real name for this localadmin is Petit-Caux

Joxit commented 4 years ago

Hi there, I updated this PR : run exportify on updated files + rebase.

stepps00 commented 4 years ago

Hey @joxit - Looks like this PR slipped through the cracks, so thanks for updating.

I suspect there is a bit more work to do here, as we need to keep the "old" name for this place (and update any name: properties. I'll also need to PIP this PR to update any descendant records. I'll take a look over the next few days and hopefully merge this work - thanks again!

Joxit commented 4 years ago

Hi @stepps00 :smile:, The old name Berneval-le-Grand is still present as locality:101900099 but the shape for the old locality is incorrect, I know we can't use OSM, but it should looks like this

Joxit commented 4 years ago

Sync with master. Do you have some news for this PR ?

stepps00 commented 4 years ago

Hi @joxit - thank you! Because this PR involves name changes, we'd need to create a new record and supersede the existing record into it. Each record also needs to be run through the exportify tools to update the wof:lastmodified date and validate the changes.

I think I can checkout your branch and make the adjustments. Let me poke around this week and push a new commit so this can be merged... stay tuned and thanks again!