Updated admin records in Luxembourg

whosonfirst-data / whosonfirst-data-admin-lu

Whos On First admin data for LU, homepage: https://whosonfirst.org

Other

0 stars 0 forks source link

Updated admin records in Luxembourg #14

Closed stepps00 closed 3 years ago

stepps00 commented 3 years ago

Fixes https://github.com/whosonfirst-data/whosonfirst-data/issues/1948.

This PR will update WOF's admin records in Luxembourg using a new public domain dataset provided by Luxembourg's Administration du cadastre et de la topographie.

To do:

[x] Merge source file in whosonfirst-sources repo (*)
[x] Cessation date for existing regions
[x] Import new regions
[x] Update localadmin placetype
[x] Update locality placetype
[x] QA neighbourhood placetype
[x] Verify name and language properties on all records in this repo
[x] Validate
[x] PIP

stepps00 commented 3 years ago

Commit Notes

523833e: Adds a cessation date to existing regions, flags them as 'not current' c764d1c: Adds twelve new region records, which represent the cantons of Luxembourg 6120c17: Updates existing WOF localadmin records and adds new localadmin from the lu-act source file 07bb092: For leftover, non-matching localadmin, deprecates and changes is_current props to 0 cbc8c2a: Updates existing WOF locality records and adds new locality from the lu-act source file 6aafb13: For leftover, non-matching localities, deprecates and changes iscurrent props to 0 929cd91: Moves all leftover locality Point records to the neighbourhood placetype, includes superseding work 61f674f: De-duplicates newly added neighbourhood records with existing records, QAs neighbourhood points e27608e: Fixes a one-off superseding issue, adds `wof:lang*properties, and removes unneccessarylbl:bbox` properties across this repo

stepps00 commented 3 years ago

@nvkelso this PR is ready for review and PIP work.

This PR updates all placetypes, updating the regions with new divisions and coterminous localadmin/locality records. This will require PIP work, which I'll add once we confirm these changes look good.

stepps00 commented 3 years ago

Also, this issue includes info on the source for this data.

nvkelso commented 3 years ago

@stepps00 let's look at these changes in QGIS this week, please. I'm able to slowly go thru the PR but lots of big geom changes make it not the best venue.

stepps00 commented 3 years ago

The changes here match expectations for Luxembourg, so the next step is to PIP this features to update hierarchies. I'll start this step soon, and should have this PR ready to merge by early next week.

stepps00 commented 3 years ago

The most recent commit includes all PIP work for this branch. I'll QA this full changeset a bit, then merge if everything looks good.