whosonfirst-data / whosonfirst-data-admin-us

Whos On First admin data for US, homepage: https://whosonfirst.org
Other
18 stars 22 forks source link

Add new US counties in CT, AK, and VA and rework related CT localadmin #207

Open nvkelso opened 3 months ago

nvkelso commented 3 months ago

Fixes https://github.com/whosonfirst-data/whosonfirst-data/issues/2197 (CT) and https://github.com/whosonfirst-data/whosonfirst-data/issues/2136 (AK and VA).

Needs full PIP

nvkelso commented 3 months ago

@stepps00 The commits in this PR should be fairly atomic and reviewable in sequence and in total.

For the counties I manually set the wof:hierarchy & etc, but really it needs a fuller PIP to account for all the child places in these counties (not just localadmin but also locality and neighbourhoods, etc).

nvkelso commented 3 months ago

I'll followup with a separate PR for the localadmin work outside of Connecticut as that affects many thousand places, but doesn't require PIP.

nvkelso commented 3 months ago

Connecticut

Old county records in black outlines (missing populations because expired geoid concordances), new counties in red with red text labels (with updated geoid concordances):

image

Existing localadmin get new geoid concordances and parent county_id hierarchies:

image

Alaska

New county records:

image

Virginia

Modified and retired county records for Bedford Co and Bedford City:

image
nvkelso commented 3 months ago

Followup outside of these new features in CT and AK for statistical gores is in https://github.com/whosonfirst-data/whosonfirst-data-admin-us/pull/208.

stepps00 commented 3 months ago

Looks good - a few comments, mostly around missing or unexpected properties. Once these features get Exportified and PIPd, I can take a second look before merge.

nvkelso commented 3 months ago

@stepps00 I've addressed your PR review comments and re-exportified everything. One more 👀 ?

Then I'll pick this up later for final PIP round.

stepps00 commented 3 months ago

A few records only have lastmodified date updates.. aside from that, LGTM. I can take another look once the PIP work is added.

ashah-lightbox commented 1 month ago

@stepps00 Any updates?

nvkelso commented 1 month ago

The next step here is to PIP update the hierarchy and parent attributes. I haven't had time to do that yet...

ashah-lightbox commented 1 month ago

@nvkelso just curious what do you mean by PIP update?

tfeathers commented 1 week ago

@nvkelso @stepps00

Is there an established process to do the PIP work? Is there anything we can do to help complete the hierarchies and get this PR over the finish line?