Open nvkelso opened 3 months ago
@stepps00 The commits in this PR should be fairly atomic and reviewable in sequence and in total.
For the counties I manually set the wof:hierarchy & etc, but really it needs a fuller PIP to account for all the child places in these counties (not just localadmin but also locality and neighbourhoods, etc).
I'll followup with a separate PR for the localadmin work outside of Connecticut as that affects many thousand places, but doesn't require PIP.
Connecticut
Old county
records in black outlines (missing populations because expired geoid concordances), new counties in red with red text labels (with updated geoid concordances):
Existing localadmin
get new geoid concordances and parent county_id hierarchies:
Alaska
New county records:
Virginia
Modified and retired county records for Bedford Co and Bedford City:
Followup outside of these new features in CT and AK for statistical gores is in https://github.com/whosonfirst-data/whosonfirst-data-admin-us/pull/208.
Looks good - a few comments, mostly around missing or unexpected properties. Once these features get Exportified and PIPd, I can take a second look before merge.
@stepps00 I've addressed your PR review comments and re-exportified everything. One more 👀 ?
Then I'll pick this up later for final PIP round.
A few records only have lastmodified date updates.. aside from that, LGTM. I can take another look once the PIP work is added.
@stepps00 Any updates?
The next step here is to PIP update the hierarchy and parent attributes. I haven't had time to do that yet...
@nvkelso just curious what do you mean by PIP update?
@nvkelso @stepps00
Is there an established process to do the PIP work? Is there anything we can do to help complete the hierarchies and get this PR over the finish line?
Fixes https://github.com/whosonfirst-data/whosonfirst-data/issues/2197 (CT) and https://github.com/whosonfirst-data/whosonfirst-data/issues/2136 (AK and VA).
Needs full PIP