search

whosonfirst / deprecated-go-whosonfirst-clone

Tools and libraries for cloning (not syncing) Who's on First data to your local machine.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Make bin fails #10

Closed vesameskanen closed 8 years ago

vesameskanen commented 8 years ago

It seems that some recent changes have broken the clone tool. The install steps of README.md give an error message when make bin is run:

src/github.com/whosonfirst/go-whosonfirst-clone/clone.go:125: cannot use abs_path (type string) as type io.Reader in argument to "github.com/whosonfirst/go-whosonfirst-csv".NewDict: string does not implement io.Reader (missing Read method)

thisisaaronland commented 8 years ago

Oh, oops. Those changes happened on Tuesday. I will fix the underlying issue and look in to "vendoring" dependencies for the future... On May 20, 2016 12:39 AM, "Vesa Meskanen" notifications@github.com wrote:

It seems that some recent changes have broken the clone tool. The install steps of README.md give an error message when make bin is run:

src/github.com/whosonfirst/go-whosonfirst-clone/clone.go:125: cannot use abs_path (type string) as type io.Reader in argument to " github.com/whosonfirst/go-whosonfirst-csv".NewDict: string does not implement io.Reader (missing Read method)

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/whosonfirst/go-whosonfirst-clone/issues/10

thisisaaronland commented 8 years ago

Fixed. Apologies for the bad craziness...

vesameskanen commented 8 years ago

Thank you! That was a quick fix .)

thisisaaronland commented 8 years ago

There is a vendor branch which should work with all the dependencies bundled in place. Do you have a moment to try it out and confirm it works?

https://github.com/whosonfirst/go-whosonfirst-clone/tree/vendor

Where "should work" means you just type "make build" as usual :-)

Cheers,

vesameskanen commented 8 years ago

Hi @thisisaaronland, I tested the vendor branch with 'make build' and after that, running a custom data cloning script for finnish data. Everything seemed to work fine.

thisisaaronland commented 8 years ago

Thanks!