search

whosonfirst / go-whosonfirst-dist

Go package for working with Who's On First distributions
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Respect compress-*=false flags #18

Open laszbalo opened 4 years ago

laszbalo commented 4 years ago

Hi,

I want to build uncompressed SQLite bundles locally. For that, I am using the following command:

./bin/wof-dist-build --build-sqlite --local-checkout -compress-sqlite=false -preserve-sqlite=true --workdir ../wof-data/ ../wof-data/whosonfirst-data-admin-ad/

After setting compress-sqlite to false, I expect this tool not to create the compressed file. However the code does not check for that flag and goes on to compress the distributions anyway.

So altered the code to work as I expected. I could send a PR if you want. However, I am not sure if you want to have any inventory file to be generated at the end of the process. Personally I don't feel the need to have one. Could you please advise on this?