Fix inconsistent wof:belongsto ordering

whosonfirst / go-whosonfirst-export

Go package for exporting Who's On First documents.

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Fix inconsistent wof:belongsto ordering #9

Closed tomtaylor closed 4 years ago

tomtaylor commented 4 years ago

The current implementation of the belongsto property checker/setter produces a lot of unnecessary changes in files, because it uses hash iteration (which is defined to be random) to set the values. This PR changes this to be deterministic.

straup commented 4 years ago

LGTM. Feel free to merge and publish a new release.

FYI, there isn't much point in separating standard library imports from external imports in the import block as the Go formatter will smush them all together in alphabetical form.

tomtaylor commented 4 years ago

I'm using a combination of gofmt and golint and whatever else the official Go plugin for VSCode does, and it seems to move all the imports around for me, so I figured it was gofmt approved?