build error - cannot find package "github.com/whosonfirst/walk"

ImreSamu commented 6 years ago

After the latest "update vendor-deps" - I have got this error message

src/github.com/whosonfirst/go-whosonfirst-crawl/crawl.go:5:2: cannot find package "github.com/whosonfirst/walk" in any of:

now ( docker log )

Step 1/2 : FROM golang:latest
 ---> 6fe15d4cbc64
Step 2/2 : RUN   git clone --quiet --depth 1 https://github.com/whosonfirst/go-whosonfirst-meta.git     && cd go-whosonfirst-meta     && make bin
 ---> Running in bb3d73e3a9bd
if test -d pkg; then rm -rf pkg; fi
if test -d src; then rm -rf src; fi
if test ! -d src; then mkdir src; fi
if test ! -d src/github.com/whosonfirst/go-whosonfirst-meta; then mkdir -p src/github.com/whosonfirst/go-whosonfirst-meta/; fi
cp  meta.go src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r meta src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r vendor/src/* src/
src/github.com/whosonfirst/go-whosonfirst-crawl/crawl.go:5:2: cannot find package "github.com/whosonfirst/walk" in any of:
    /usr/local/go/src/github.com/whosonfirst/walk (from $GOROOT)
    /go/go-whosonfirst-meta/src/github.com/whosonfirst/walk (from $GOPATH)
make: *** [bin] Error 1
Makefile:49: recipe for target 'bin' failed

the previous version was ok

Step 1/2 : FROM golang:latest
 ---> 6fe15d4cbc64
Step 2/2 : RUN   git clone --quiet --depth 20 https://github.com/whosonfirst/go-whosonfirst-meta.git     && cd go-whosonfirst-meta     && git checkout 08661604947679f614330e849e62c47bfa240bbb     && make bin
 ---> Running in 678b9d855810
Note: checking out '08661604947679f614330e849e62c47bfa240bbb'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 0866160... update all the distributions
if test -d pkg; then rm -rf pkg; fi
if test -d src; then rm -rf src; fi
if test ! -d src; then mkdir src; fi
if test ! -d src/github.com/whosonfirst/go-whosonfirst-meta; then mkdir -p src/github.com/whosonfirst/go-whosonfirst-meta/; fi
cp  meta.go src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r meta src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r vendor/src/* src/
Removing intermediate container 678b9d855810
 ---> 4a5681573d06
Successfully built 4a5681573d06
Successfully tagged wdd1:latest

thisisaaronland commented 6 years ago

Try now? This package was using an old (incorrect) vendoring path scheme.

ImreSamu commented 6 years ago

Perfect! Thank you! :+1:

my test (docker)log:

Step 1/2 : FROM golang:latest
 ---> 6fe15d4cbc64
Step 2/2 : RUN  git clone --quiet https://github.com/whosonfirst/go-whosonfirst-meta.git     && cd go-whosonfirst-meta     && git rev-parse HEAD     && make bin
 ---> Running in 7e54915e3f3e
c3d37e22ba604948da19754b9eaecd7683ba303e
if test -d pkg; then rm -rf pkg; fi
if test -d src; then rm -rf src; fi
if test ! -d src; then mkdir src; fi
if test ! -d src/github.com/whosonfirst/go-whosonfirst-meta; then mkdir -p src/github.com/whosonfirst/go-whosonfirst-meta/; fi
cp  meta.go src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r meta src/github.com/whosonfirst/go-whosonfirst-meta/
cp -r vendor/* src/
Removing intermediate container 7e54915e3f3e
 ---> e5b4ba5432cb
Successfully built e5b4ba5432cb

whosonfirst / go-whosonfirst-meta

build error - cannot find package "github.com/whosonfirst/walk" #7