search

whosonfirst / go-whosonfirst-pgis

This is not ready to use. It is still being tested. It will probably be renamed.
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Password is required param, but does not error if unprovided #1

Closed sosso closed 7 years ago

sosso commented 7 years ago

bin/wof-pgis-index -mode=repo -pgis-user=myusername -verbose=true -strict=true -pgis-database=mydb -pgis-maxconns=1 ~/workspace/whosonfirst-data-venue-us-ca

If password is left off, the dsn becomes

host=localhost port=5432 user=myusername password= dbname=mydb sslmode=disable and it's unable to find the relation whosonfirst. I think it's because the DSN becomes invalid, but pq just keeps chugging along. Might be good to document.

thisisaaronland commented 7 years ago

Okay, the dsn shouldn't contain a password= config if it's empty when the db client is created. Thanks for the head up.