search

whosonfirst / go-whosonfirst-pip-v2

An in-memory point-in-polygon (reverse geocoding) package for GeoJSON data, principally Who's On First data.
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Include concordances in response? #33

Closed kochis closed 4 years ago

kochis commented 4 years ago

Is there a way to include the concordances in the response?

Seems like this would probably need to happen during the index phase, not sure if there was an easy way to configure this or not.

Thanks!

thisisaaronland commented 4 years ago

The closest thing would be using the experimental "extras" feature:

https://github.com/whosonfirst/go-whosonfirst-pip-v2#extras

That work hasn't been touched in a long time so it might be a bit wobbly.

kochis commented 4 years ago

Yeah, I was looking at that. I’ll take a stab and see how it works out. Thanks for the quick response.

thisisaaronland commented 4 years ago

The PIP codebase is overdue a bit of a refactoring so any comments, suggestions and (gentle :-) cluebats about things, and the extras in particular, stuff are welcome.

kochis commented 4 years ago

Starting with -enable-extras was able to do the trick (along with the extras=wof:* param)